[Q-e-developers] 5.1 Tarball issues

[Paolo Giannozzi]

Hi

thank you for your remarks.

1. The proper place for PlotPhon/ and QHA/ is inside PHonon/ in my
   opinion. Actually they should be both merged with other phonon
   utilities, but it takes time, effort, and I feel a little bit
   embarrassed in making major changes to PlotPhon and QHA, since 
   their author is no longer with us.

2. I hadn't noticed that PWgui is ready for automatic downloading
   and should follow the same logic of other packages. I have updated
   the PWgui package, removing the espresso-5.1/ directory.

3. The capitalization of subdirectories comes from old problems with
   "make something" not working if directory something/ was present.
   I have no strong opinions on this: I have just followed what has
   been done until now. I would prefer not to change directory names,
   though.

Paolo

> sorry for looking so (too?) late at it, but I'd like to point out a
> couple of (not really dramatic, but problematic for packagers like me)
> issues in the 5.1 tarballs:
> 
> 1. The PHonon tarball as grown multiple top-level directories, namely
> PHonon (was there before), as well as PlotPhon and QHA. I think this is
> quite bad style and I am afraid that additionally this might break the
> multiple-tarball-in-a-source-package distribution of Debian/Ubuntu (see
> footnote [1] below for how that works). Not sure what a correct fix
> would be like, maybe splitting PlotPhon QHA off as a seperate tarball?
> 
> 2. The PWgui tarball has a superfluous espresso-5.1 directory next to
> the PWgui-5.1 directory, this was not the case for 5.0.x.  Not sure how
> bad that is, are people supposed to extract PWgui in the main
> espresso-5.1 directory like the other packages (e.g. neb, tddfpt)? Then
> you'd end up with espresso-5.1/espresso-5.1/PWgui-5.1.  On the other
> hand, not sure why PWgui would be special-cased as the only module to be
> extracted from outside the espresso-5.1 directory or elsewhere
> entirely, but why then have an espresso-5.1 directory in there in the
> first place?
> 
> 3. As an aside, it wouldn't hurt if the capitalization between the
> tarball name and the top-level directory inside the tarball would be
> consistent, e.g. tddfpt-5.1.tar.gz extracts to TDDFPT/ and
> xspectra-5.1.tar.gz extracts to XSpectra/, but GWW-5.1.tar.gz extracts
> to GWW/ as expected (I'd vote for changing the tarball names to be
> consistent with the directories).  So far I have just renamed the
> tarballs accordingly for the Debian package, which I can do again[1],
> just wanted to mention it while i'm at it.
> 
> Probably this is too late now and I will have to hack around for it for
> 5.1, but better late than never... In any case congrats to the imminent
> release of QE-5.1!
> 
> 
> Michael
> 
> [1] I have to rename the tarball names due to an internal implementation
> on how multipiple tarballs are handled in Debian, namely
> espresso_5.1.orig-$foo.tar.gz gets automatically extracted to $foo in
> the espresso-5.1 directory by dpkg-source. This is exactly what I/we want,
> except the capitalization is carried over. But as I have to rename from
> tddfpt-5.1.tar.gz to espresso_5.1.orig-tddfpt.tar.gz anyway to make this
> work, I can change it to espresso_5.1.orig-TDDFPT.tar.gz while I'm at
> it.
> _______________________________________________
> Q-e-developers mailing list
> Q-e-developers at qe-forge.org
> http://qe-forge.org/mailman/listinfo/q-e-developers