[Q-e-developers] Small fix for XLF compiler on Blue Gene/Q

[William Parker]

I just wanted to say thanks to Paolo for fixing this.  I updated the svn version and recompiled on Blue Gene/Q without a hitch.  The executable seems to run fine.

--William

On Jun 6, 2014, at 11:16 AM, Paolo Giannozzi <paolo.giannozzi at uniud.it> wrote:

> On Wed, 2014-06-04 at 14:58 -0500, William Parker wrote:
> 
>> I noticed that I had to edit the second USE line in
>> Modules/xml_input.f90 to:
>> 
>>   USE xml_io_base, ONLY : attr, write_header
>> 
>> in order to compile v5.1 pw.x on our Blue Gene/Q.
> 
> finally I figured out why: write_header is called only in subroutine
> xml_input_dump. This routine contains a "return" as first operation,
> so it does nothing. Apparently most compilers (rightly) assume that 
> what follows doesn't matter, while your compiler decided otherwise,
> finding a missing reference.
> 
> I have removed write_header in xml_io_base, because it is a duplicate
> of "qexml_write_header". Not sure what to do with the xml_input_dump
> routine, since I don't know whether it is supposed to be disabled or
> not. 
> 
> paolo
> 
>> Is this something that should be fixed generally or done with a the
>> XLF preprocessor flag? 
>> 
>> 
>> Please advise.
>> 
>> 
>> --William
>> 
>> *********************************************************
>>  William D. Parker              phone: +1 (630) 252-3388
>>  Argonne Scholar
>>  Argonne Leadership Computing Facility
>>  Building 240, Office 1-D.16
>>  Argonne National Laboratory
>>  9700 S. Cass Ave.
>>  Argonne, IL 60439
>>  U.S.A.
>> *********************************************************
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Q-e-developers mailing list
>> Q-e-developers at qe-forge.org
>> http://qe-forge.org/mailman/listinfo/q-e-developers
> 
> -- 
> Paolo Giannozzi, Dept. Chemistry&Physics&Environment, 
> Univ. Udine, via delle Scienze 208, 33100 Udine, Italy
> Phone +39-0432-558216, fax +39-0432-558222 
> 
> _______________________________________________
> Q-e-developers mailing list
> Q-e-developers at qe-forge.org
> http://qe-forge.org/mailman/listinfo/q-e-developers