[Q-e-developers] Next QE release

[Paolo Giannozzi]

Done, thank you

Paolo

On Fri, Sep 23, 2016 at 2:23 PM, Michael Banck <mbanck at debian.org> wrote:

> On Sun, Oct 26, 2014 at 10:47:33PM +0100, Michael Banck wrote:
> > On Sun, Oct 26, 2014 at 09:44:42PM +0100, Paolo Giannozzi wrote:
> > > > 2. The copyright violations in TDDFPT/ColorCalculator have not been
> > > > fixed it seems.
>
> The latest development snapshot still seems to have class-files without
> corresponding code in it:
>
> $ tar tf espresso-r12956-2016-09-11.tar.gz | grep TDDFPT.*class$ | wc -l
> 685
> $ tar tf espresso-r12956-2016-09-11.tar.gz | grep TDDFPT.*java$ | wc -l
> 5
>
> > > you mean: the presence of the two binaries colorCalculator4.jar and
> > > ColorCalculator5.jar? Removed, there are instructions on how to compile
> > > them.
> >
> > Well that, and all the .class files which do not have a corresponding
> > source (.java) file, as they are from 3rd-party modules.
> >
> > I had a quick look, and the two Debian package libjcommon-java and
> > libjfreechart-java seem to provide those .class files in their .jars.
> >
> > So there are two options after removing the .class files:
> >
> > 1. Adjust README/Install to tell the user to download those .jars from
> > elsewhere and add them to the classpath when assembling the jar.
> >
> > 2.  Include the corresponding .java files for those.  However, that'll
> > make compilation a bit more difficult, but maybe 'javac `find . -name
> > "*.java"`' would suffice already.
>
> Or
>
> 3. Adjust README/Install to download the jars automatically if they are
> not present.
>
> I've done that now in the attached patch which works for me.  With that,
> TDDFPT/ColorCalculator/src/{com,org} can be removed from the source
> tree.
>
> The alternative would be to just remove the ColorCalculator program
> entirely.
>
>
> Michael
>
> _______________________________________________
> Q-e-developers mailing list
> Q-e-developers at qe-forge.org
> http://qe-forge.org/mailman/listinfo/q-e-developers
>
>


-- 
Paolo Giannozzi, Dip. Scienze Matematiche Informatiche e Fisiche,
Univ. Udine, via delle Scienze 208, 33100 Udine, Italy
Phone +39-0432-558216, fax +39-0432-558222
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.quantum-espresso.org/pipermail/developers/attachments/20160923/8c47a47f/attachment.html>