<div dir="ltr"><div><div><div>Dear Filippo, <br><br></div>Can I run the script ./refresh-configure.sh and commit to the trunk?<br><br></div>Best, <br><br></div>Samuel<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 May 2016 at 14:43, Filippo Spiga <span dir="ltr"><<a href="mailto:filippo.spiga@quantum-espresso.org" target="_blank">filippo.spiga@quantum-espresso.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div>Paolo already committed some changes related to this (the configure has to be regenerated,  autoconf v2.69 is a minimum required then it is just a matter of run the script "refresh-confogure.sh" in "install/").</div><div><br></div><div>Let see how it goes</div><div><br>--<div>Filippo SPIGA</div><div>* Sent from my iPhone, sorry for typos *</div></div><div><div class="h5"><div><br>On 19 May 2016, at 20:01, Samuel Poncé <<a href="mailto:samuel.pon@gmail.com" target="_blank">samuel.pon@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">As Martin mentioned, this problem is only when the compiler does not come with preprocessing 'integrated'.  <br><div><br>If Filippo agrees, I would suggest to put<br><div><br>CPPFLAGS       = -P -traditional $(DFLAGS) $(IFLAGS) $(MANUAL_DFLAGS)<br><br></div><div>only in the case of pgi. <br><br></div><div>Best, <br><br></div><div>Samuel. <br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 18 May 2016 at 14:18, Martin Schlipf <span dir="ltr"><<a href="mailto:martin.schlipf@gmail.com" target="_blank">martin.schlipf@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    To my understanding, the gcc C preprocessor (v4.8.5) does not work
    with the option -C, because it adds an unwanted C style comment that
    the fortran compiler cannot process. Furthermore, the option -C has
    not the intended effect (to keep the comments) on fortran files,
    because it is not implemented. From the documentation<br>
    <a href="https://gcc.gnu.org/onlinedocs/gfortran/Preprocessing-Options.html" target="_blank">https://gcc.gnu.org/onlinedocs/gfortran/Preprocessing-Options.html</a><br>
    <br>
    Warning: this currently handles C-Style comments only. The
    preprocessor does not yet recognize Fortran-style comments. <br>
    <br>
    The comments are always kept, even if -C is not set. So I would
    suggest to remove the flag.<br>
    <br>
    The only disadvantage of removing the -C flag is when the project
    contains both C and fortran files, where the -C option might be
    wanted for the C files. In this case, one could replace cpp with gcc
    -cpp -E, which also doesn't add the C-style comment for some reason.<br>
    <br>
    Note, that this only affects the specific case, where we need to do
    the preprocessing separately from the compilation, i.e., when the
    compiler does not come with an option to do preprocessing +
    compilation in a single step, and only if the gcc C preprocessor is
    used.<span><font color="#888888"><br>
    <br>
    Martin</font></span><div><div><br>
    <br>
    <div>On 18/05/16 13:34, Paolo Giannozzi
      wrote:<br>
    </div>
    <blockquote type="cite">
      <div dir="ltr">
        <div>So what is the final agreement? is it a problem of a
          specific version of PGI, or a general problem affecting other
          compilers as well? Axel says that cpp -P -C has been used
          since years to preprocess fortran files<br>
          <br>
        </div>
        Paolo<br>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Wed, May 18, 2016 at 11:45 AM,
          Samuel Poncé <span dir="ltr"><<a href="mailto:samuel.pon@gmail.com" target="_blank">samuel.pon@gmail.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr">
              <div>
                <div>
                  <div>
                    <div>
                      <div>
                        <div>
                          <div>Hello Filippo, <br>
                            <br>
                          </div>
                          Just to finish. The version of pgi is <br>
                          pgfortran --version<br>
                          <br>
                          pgfortran 15.7-0 64-bit target on x86-64 Linux
                          -tp core2 <br>
                          <span>The Portland Group - PGI
                            Compilers and Tools<br>
                          </span>Copyright (c) 2015, NVIDIA
                          CORPORATION.  All rights reserved<br>
                          <br>
                        </div>
                        with gcc (GCC) 4.8.5 for the CPP.<br>
                        <br>
                      </div>
                      The bot that does that test can be found at <a href="http://129.67.86.21:8010/builders/EPW-farm2_pgi15/builds/38/steps/make_pw/logs/stdio" target="_blank"></a><a href="http://129.67.86.21:8010/builders/EPW-farm2_pgi15/builds/38/steps/make_pw/logs/stdio" target="_blank">http://129.67.86.21:8010/builders/EPW-farm2_pgi15/builds/38/steps/make_pw/logs/stdio</a><br>
                      <br>
                    </div>
                    As a side note, I was never able to compile QE with
                    pgi 12.10. <br>
                  </div>
                  Since its an old version, I gave up testing it. <br>
                  <br>
                </div>
                Best, <br>
              </div>
              <div>Sam<br>
              </div>
              <div>
                <div>
                  <div>
                    <div>
                      <div><br>
                        <div><br>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </div>
            </div>
            <div class="gmail_extra">
              <div>
                <div><br>
                  <div class="gmail_quote">On 17 May 2016 at 10:17,
                    Filippo SPIGA <span dir="ltr"><<a href="mailto:filippo.spiga@quantum-espresso.org" target="_blank"></a><a href="mailto:filippo.spiga@quantum-espresso.org" target="_blank">filippo.spiga@quantum-espresso.org</a>></span>
                    wrote:<br>
                    <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Interesting
                      Martin, thanks for let us know. I have several
                      builds of GCC on the cluster, let me play a bit
                      swapping them !<br>
                      <span><br>
                        On May 17, 2016, at 5:15 PM, Martin Schlipf <<a href="mailto:martin.schlipf@gmail.com" target="_blank"></a><a href="mailto:martin.schlipf@gmail.com" target="_blank">martin.schlipf@gmail.com</a>>
                        wrote:<br>
                        > Hello Filippo,<br>
                        ><br>
                      </span><span>> the builder that compiles with
                        PGI uses gcc 4.8.5 for the preprocessing.<br>
                        > I tested an older version 4.4.7, which does
                        not add the additional<br>
                        > C-style comment.<br>
                        <br>
                      </span>
                      <div>
                        <div>--<br>
                          Mr. Filippo SPIGA, M.Sc.<br>
                          Quantum ESPRESSO Foundation<br>
                          <a href="http://www.quantum-espresso.org" rel="noreferrer" target="_blank">http://www.quantum-espresso.org</a>
                          ~ skype: filippo.spiga<br>
                          <br>
                          *****<br>
                          Disclaimer: "Please note this message and any
                          attachments are CONFIDENTIAL and may be
                          privileged or otherwise protected from
                          disclosure. The contents are not to be
                          disclosed to anyone other than the addressee.
                          Unauthorized recipients are requested to
                          preserve this confidentiality and to advise
                          the sender immediately of any error in
                          transmission."<br>
_______________________________________________<br>
                          Q-e-developers mailing list<br>
                          <a href="mailto:Q-e-developers@qe-forge.org" target="_blank">Q-e-developers@qe-forge.org</a><br>
                          <a href="http://qe-forge.org/mailman/listinfo/q-e-developers" rel="noreferrer" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a><br>
                        </div>
                      </div>
                    </blockquote>
                  </div>
                  <br>
                  <br clear="all">
                  <br>
                </div>
              </div>
              <span>-- <br>
                <div>
                  <div dir="ltr"><span><font color="#888888">
                        <pre cols="72">------------------------------------------------------------------------------------------------
    Dr. Samuel Poncé  
    Department of Materials
    University of Oxford
    Parks Road
    Oxford OX1 3PH, UK

    Phone: <a href="tel:%2B44%201865%20612789" value="+441865612789" target="_blank">+44 1865 612789</a>
    email: <a href="mailto:samuel.ponce@materials.ox.ac.uk" target="_blank">samuel.ponce@materials.ox.ac.uk</a> 
    web: <a href="http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9" target="_blank">http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9</a>
------------------------------------------------------------------------------------------------</pre>
                      </font></span></div>
                </div>
              </span></div>
            <br>
            _______________________________________________<br>
            Q-e-developers mailing list<br>
            <a href="mailto:Q-e-developers@qe-forge.org" target="_blank">Q-e-developers@qe-forge.org</a><br>
            <a href="http://qe-forge.org/mailman/listinfo/q-e-developers" rel="noreferrer" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a><br>
            <br>
          </blockquote>
        </div>
        <br>
        <br clear="all">
        <br>
        -- <br>
        <div>
          <div dir="ltr">
            <div>
              <div dir="ltr">
                <div>Paolo Giannozzi, Dip. Scienze Matematiche
                  Informatiche e Fisiche,<br>
                  Univ. Udine, via delle Scienze 208, 33100 Udine, Italy<br>
                  Phone <a href="tel:%2B39-0432-558216" value="+390432558216" target="_blank">+39-0432-558216</a>, fax <a href="tel:%2B39-0432-558222" value="+390432558222" target="_blank">+39-0432-558222</a><br>
                  <br>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
Q-e-developers mailing list
<a href="mailto:Q-e-developers@qe-forge.org" target="_blank">Q-e-developers@qe-forge.org</a>
<a href="http://qe-forge.org/mailman/listinfo/q-e-developers" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a>
</pre>
    </blockquote>
    <br>
  </div></div></div>

<br>_______________________________________________<br>
Q-e-developers mailing list<br>
<a href="mailto:Q-e-developers@qe-forge.org" target="_blank">Q-e-developers@qe-forge.org</a><br>
<a href="http://qe-forge.org/mailman/listinfo/q-e-developers" rel="noreferrer" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div><div dir="ltr"><span><font color="#888888"><pre cols="72">------------------------------------------------------------------------------------------------
    Dr. Samuel Poncé  
    Department of Materials
    University of Oxford
    Parks Road
    Oxford OX1 3PH, UK

    Phone: <a href="tel:%2B44%201865%20612789" value="+441865612789" target="_blank">+44 1865 612789</a><br>    email: <a href="mailto:samuel.ponce@materials.ox.ac.uk" target="_blank">samuel.ponce@materials.ox.ac.uk</a> <a href="mailto:fabio.caruso@materials.ox.ac.uk" target="_blank"></a>
    web: <a href="http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9" target="_blank">http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9</a>
------------------------------------------------------------------------------------------------</pre></font></span></div></div>
</div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Q-e-developers mailing list</span><br><span><a href="mailto:Q-e-developers@qe-forge.org" target="_blank">Q-e-developers@qe-forge.org</a></span><br><span><a href="http://qe-forge.org/mailman/listinfo/q-e-developers" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a></span><br></div></blockquote></div></div></div><br>_______________________________________________<br>
Q-e-developers mailing list<br>
<a href="mailto:Q-e-developers@qe-forge.org">Q-e-developers@qe-forge.org</a><br>
<a href="http://qe-forge.org/mailman/listinfo/q-e-developers" rel="noreferrer" target="_blank">http://qe-forge.org/mailman/listinfo/q-e-developers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><span><font color="#888888"><pre cols="72">------------------------------------------------------------------------------------------------
    Dr. Samuel Poncé  
    Department of Materials
    University of Oxford
    Parks Road
    Oxford OX1 3PH, UK

    Phone: +44 1865 612789<br>    email: <a href="mailto:samuel.ponce@materials.ox.ac.uk" target="_blank">samuel.ponce@materials.ox.ac.uk</a> <a href="mailto:fabio.caruso@materials.ox.ac.uk" target="_blank"></a>
    web: <a href="http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9" target="_blank">http://giustino.materials.ox.ac.uk/index.php/Site/SamuelPonc%e9</a>
------------------------------------------------------------------------------------------------</pre></font></span></div></div>
</div>